[asterisk-dev] kFreeBSD: __FreeBSD_kernel__ and not __GLIBC__ [was: Re: [svn-commits] tzafrir: trunk r282397 - in /trunk: ./ channels/ main/ utils/]

[Tzafrir Cohen]

Long ago, On Sun, Aug 15, 2010 at 01:08:59PM -0000, SVN commits to the Digium repositories wrote:
> Author: tzafrir
> Date: Sun Aug 15 08:08:45 2010
> New Revision: 282397
> 
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=282397
> Log:
> Support for GNU/kFreeBSD
> 
> kFreeBSD is GNU (with glibc) on to of a FreeBSD kernel. See
> http://glibc-bsd.alioth.debian.org/porting/PORTING
> 
> This patch gets Asterisk close to building on Debian kFreeBSD i386,
> mainly by adding an extra test for __GLIBC__ in one or two (or more)
> places.

Well, later on the kFreeBSD porters advised me that it would be better
to use __FreeBSD_kernel__ and not __GLIBC__.

A quick grep for __GLIBC__ does not bring up any other uses of it that
should be fixed beyond the ones in this patch:

main/ast_expr2.c:#  if defined __GLIBC__ && defined _STRING_H
main/ast_expr2.c:#  if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE
main/editline/config.guess:      # ifdef __GLIBC__
main/editline/config.guess:      #  if __GLIBC__ >= 2
main/stdtime/private.h:** start, since __GLIBC__'s value depends on previously-included
main/stdtime/private.h:  2 < (__GLIBC__ + (0 < __GLIBC_MINOR__)))
res/ael/ael.tab.c:#  if defined __GLIBC__ && defined _STRING_H
res/ael/ael.tab.c:#  if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE

All of those don't seem to be related.

> 
> OSARCH is set to 'kfreebsd-gnu'
> 
> DAHDI support (and support for chan_vpb) was not tested.
> 
> Modified:
>     trunk/channels/chan_oss.c
>     trunk/configure
>     trunk/configure.ac
>     trunk/main/Makefile
>     trunk/main/acl.c
>     trunk/main/netsock.c
>     trunk/utils/muted.c
> 
> Modified: trunk/channels/chan_oss.c
> URL: http://svnview.digium.com/svn/asterisk/trunk/channels/chan_oss.c?view=diff&rev=282397&r1=282396&r2=282397

Fix that?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir