[asterisk-dev] [Code Review]: use ie2str(full_ie) where possible in q931.c

[rmudgett]

> On Dec. 19, 2011, 11:10 a.m., rmudgett wrote:
> > branches/1.4/q931.c, lines 3602-3603
> > <https://reviewboard.asterisk.org/r/1633/diff/2/?file=22270#file22270line3602>
> >
> >     Reexamine what this change will do to the output.  For the shift codes, ie2str() decodes more.  "Locking Shift To Codeset 1"
> 
> Alec Davis wrote:
>     Maybe this is one that doesn't use ie2str.

I suppose reverting this change would be best since this is a single octet ie and it is treated specially in the decode anyway.


> On Dec. 19, 2011, 11:10 a.m., rmudgett wrote:
> > branches/1.4/q931.c, lines 1507-1515
> > <https://reviewboard.asterisk.org/r/1633/diff/2/?file=22270#file22270line1507>
> >
> >     Why 'dump_channel_id' left is? :)
> 
> Alec Davis wrote:
>     To keep the formatted output 'formatted' I left it as is, I can change the string array description from "Channel Identification" to "Channel ID"

I don't think making this use ie2str(full_ie) would mess up the formatting much with the following lines.
You could try it to see how it looks and then change the ies[] to "Channel ID" if it doesn't look good.

Other places where the dumped name changes:
"Called Number" --> "Called Party Number"
"Calling Number" --> "Calling Party Number"
"Redirecting Number" --> "Redirecting Number" and "Redirecting Number" --> "Original Called Number"


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1633/#review5028
-----------------------------------------------------------


On Dec. 19, 2011, 3:56 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1633/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2011, 3:56 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> compiles
> 
> Only 'dump_channel_id' left is.
> 
> 
> Diffs
> -----
> 
>   branches/1.4/q931.c 2279 
> 
> Diff: https://reviewboard.asterisk.org/r/1633/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111219/f13e40a5/attachment.htm>