[asterisk-dev] [Code Review] Add basic dialplan tests to the testsuite

jrose reviewboard at asterisk.org
Tue Dec 13 16:42:38 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1621/#review5005
-----------------------------------------------------------


I think it could benefit from having a user event at the end of every portion of the test that gets logged so that you could easily figure out which part of the test failed, but this looks nice and clean to me.

- jrose


On Dec. 13, 2011, 4:27 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1621/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 4:27 p.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Leif Madsen.
> 
> 
> Summary
> -------
> 
> This patch adds a dialplan test to the testsuite.  The dialplan itself contains a number of 'tests' that exercise basic dialplan functions and applications.
> 
> This test is meant as a starting point for additional work - not all dialplan functions / apps are currently tested, but markers for future additions have been added to the supplied extensions.conf.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/dialplan/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/dialplan/run-test PRE-CREATION 
>   /asterisk/trunk/tests/dialplan/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 2868 
> 
> Diff: https://reviewboard.asterisk.org/r/1621/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111213/915ee8b7/attachment.htm>


More information about the asterisk-dev mailing list