[asterisk-dev] [Code Review]: Support a hint on a queue.

[schmidts]

> On Dec. 13, 2011, 2:31 a.m., Olle E Johansson wrote:
> > I think this is a good addition. I created something similar with custom devstates in the dial plan earlier, but it was a bit messy. You might want to complete the devstate addition with ast_devstate_prov_add() and ast_devstate_prov_del() with the callbacks.

i also think this is a good adition but i think it would be better to stay at the hint scheme and use something like exten => 123,hint,QUEUE/night_queue instead of Queue:. 


- schmidts


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1619/#review4996
-----------------------------------------------------------


On Dec. 12, 2011, 9:45 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1619/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2011, 9:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Note: the 2 debug print lines will go.
> 
> Picking up queues is possible, but knowing that a queue is ringing is useful,
> particulary when you are not logged in to that queue, or not a member of it.
> 
> Non BLF users, dial 72# and then are connected with caller.
> If they forget to press # or the SEND button they think the pickup hasn't worked.
> Not understanding there is a 3-4 second delay before the SIP call is placed.
> 
> exten => 72,hint,Queue:night_queue ;queue NIGHT BELL
> 
> exten => _72,1,NoOp(Pickup Night Bell)
> exten => _72,n,Pickup(4999 at isdn)    ;direct call pickup to local Asterisk
> exten => _72,n,NoOp(PICKUPRESULT=${PICKUPRESULT})
> exten => _72,n,Hangup()
> 
> exten => **72,1,Goto(72,1)
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 348014 
> 
> Diff: https://reviewboard.asterisk.org/r/1619/diff
> 
> 
> Testing
> -------
> 
> In use for months on a 1.8.5 production box.
> 
> NightBell usage:
> 
> Users with BLFs configured hear the nightbells, and see the BLF flash, press the BLF and are immediately connected with caller.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111213/87d98431/attachment-0001.htm>