[asterisk-dev] [Code Review]: Make weak reference support linux and MacOSX only.

[Tilghman Lesher]

> On Dec. 12, 2011, 10:44 a.m., Tilghman Lesher wrote:
> > /branches/1.8/configure.ac, lines 910-912
> > <https://reviewboard.asterisk.org/r/1617/diff/2/?file=22197#file22197line910>
> >
> >     Again, you also need cases for "freebsd*", "netbsd*", and "openbsd*".
> 
> rmudgett wrote:
>     Please see the description for this review.  The feature is supported for Linux (And Mac OS X *only* because there is *active* community support.).

I think you'll find active community support even for FreeBSD.  I'm sure there's some for OpenBSD, too, although I'm unsure of the support for NetBSD.

However, given that is _just_ _works_ on these platforms, it seems silly that we're nickel-and-diming these platforms.  Solaris, I can understand, given that it's a closed-source commercial package -- and that is the extent of the bug to which you've referred.  Dropping support for other platforms where it works exactly the same way as it does on Linux (because they use exactly the same tools) is nonsensical.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1617/#review4991
-----------------------------------------------------------


On Dec. 9, 2011, 3:44 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1617/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 3:44 p.m.)
> 
> 
> Review request for Asterisk Developers, Kevin Fleming, Olle E Johansson, and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> Weak references is not portable and either does not work or does not work as expected on other platforms.
> 
> Primarily support weak references on linux platforms because the feature just works.
> 
> Allow weak symbol support on MacOS/X platforms only because there is active community support for it.  However, MacOS/X seems to break weak symbols for each new version.
> 
> 
> This addresses bugs ASTERISK-18728 and ASTERISK-18950.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18728
>     https://issues.asterisk.org/jira/browse/ASTERISK-18950
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/configure UNKNOWN 
>   /branches/1.8/configure.ac 347865 
> 
> Diff: https://reviewboard.asterisk.org/r/1617/diff
> 
> 
> Testing
> -------
> 
> My linux box now configures for HAVE_ATTRIBUTE_weakref instead of HAVE_ATTRIBUTE_weak which is Darwin specific. 
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111212/66102a52/attachment-0001.htm>