[asterisk-dev] [Code Review]: Add manager event for early media

[rmudgett]

> On Dec. 9, 2011, 8:44 a.m., jrose wrote:
> > Truth be told, progress isn't really a state... it's just an indication.  Usually I think it's just used for Early Media, but I don't really know all the implications behind it, so it might be proper to call it an indication event.  But you seem to have already talked with Russell about this a while back going on the conversation in here and came to the conclusion that this wouldn't work for some reason.
> > 
> > The only thing I'm at all worried about at this point is that we come back later and decide that this really should have been a different kind of event and have to make an option to keep this behavior instead of just discarding it outright.  Even then it wouldn't be that horribly big of a deal, and I generally agree with having an ami event for tracking this, so you can go ahead and commit this.
> 
> Russell Bryant wrote:
>     I don't remember the discussion oej references (we probably did talk about it, I just don't remember).  
>     
>     FWIW, just looking at this review, I still agree with my past self that this is not a channel state, so using the NewState event is wrong.

Progress is not a state and I agree that reporting it as a state is wrong.  Q,931 specifically states that the PROGRESS message does not change the call state.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1187/#review4970
-----------------------------------------------------------


On Sept. 19, 2011, 6:43 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1187/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 6:43 a.m.)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Add a manager event for early media. Using the existing Newstate event with a "faked" state called "progress". 
> 
> In the long run, this is not the right thing to do, but after discussion with Russell on asterisk-dev it was concluded that it was the easiest way forward.
> 
> 
> This addresses bug 19135.
>     https://issues.asterisk.org/jira/browse/19135
> 
> 
> Diffs
> -----
> 
>   /team/oej/bring-in-the-early-media-trunk/apps/app_dial.c 332755 
>   /team/oej/bring-in-the-early-media-trunk/main/pbx.c 332755 
> 
> Diff: https://reviewboard.asterisk.org/r/1187/diff
> 
> 
> Testing
> -------
> 
> Tested many calls in the 1.4 version of the same patch. 
> 
> One-legged calls using the progress() dialplan app, two legged calls using dial().
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/5df66924/attachment-0001.htm>