[asterisk-dev] [Code Review] Make weak reference support linux and MacOSX only.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1617/
-----------------------------------------------------------

(Updated Dec. 9, 2011, 3:44 p.m.)


Review request for Asterisk Developers, Kevin Fleming, Olle E Johansson, and Tilghman Lesher.


Changes
-------

Address Kevin's comments.


Summary
-------

Weak references is not portable and either does not work or does not work as expected on other platforms.

Primarily support weak references on linux platforms because the feature just works.

Allow weak symbol support on MacOS/X platforms only because there is active community support for it.  However, MacOS/X seems to break weak symbols for each new version.


This addresses bugs ASTERISK-18728 and ASTERISK-18950.
    https://issues.asterisk.org/jira/browse/ASTERISK-18728
    https://issues.asterisk.org/jira/browse/ASTERISK-18950


Diffs (updated)
-----

  /branches/1.8/configure UNKNOWN 
  /branches/1.8/configure.ac 347865 

Diff: https://reviewboard.asterisk.org/r/1617/diff


Testing
-------

My linux box now configures for HAVE_ATTRIBUTE_weakref instead of HAVE_ATTRIBUTE_weak which is Darwin specific. 


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/2a15dfff/attachment.htm>