[asterisk-dev] [Code Review] Make weak reference support linux and MacOSX only.

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1617/#review4985
-----------------------------------------------------------

Ship it!


Other than some comment changes, this looks good to me.


/branches/1.8/configure.ac
<https://reviewboard.asterisk.org/r/1617/#comment9245>

    s/linux/Linux/



/branches/1.8/configure.ac
<https://reviewboard.asterisk.org/r/1617/#comment9246>

    Be consistent here. 'Mac OS/X' is the most common way to refer to this platform, but in this case referring to 'Darwin' would also be appropriate.



/branches/1.8/configure.ac
<https://reviewboard.asterisk.org/r/1617/#comment9247>

    s/Sevaral/Several/;s/linux/Linux/



/branches/1.8/configure.ac
<https://reviewboard.asterisk.org/r/1617/#comment9248>

    Refer to Darwin here as well.


- Kevin


On Dec. 9, 2011, 1:57 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1617/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 1:57 p.m.)
> 
> 
> Review request for Asterisk Developers, Kevin Fleming, Olle E Johansson, and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> Weak references is not portable and either does not work or does not work as expected on other platforms.
> 
> Primarily support weak references on linux platforms because the feature just works.
> 
> Allow weak symbol support on MacOS/X platforms only because there is active community support for it.  However, MacOS/X seems to break weak symbols for each new version.
> 
> 
> This addresses bugs ASTERISK-18728 and ASTERISK-18950.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18728
>     https://issues.asterisk.org/jira/browse/ASTERISK-18950
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/configure UNKNOWN 
>   /branches/1.8/configure.ac 347865 
> 
> Diff: https://reviewboard.asterisk.org/r/1617/diff
> 
> 
> Testing
> -------
> 
> My linux box now configures for HAVE_ATTRIBUTE_weakref instead of HAVE_ATTRIBUTE_weak which is Darwin specific. 
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/954d424a/attachment.htm>