[asterisk-dev] [Code Review]: Add manager event for early media

[jrose]

> On Dec. 9, 2011, 8:47 a.m., jrose wrote:
> > /team/oej/bring-in-the-early-media-trunk/main/pbx.c, lines 9292-9305
> > <https://reviewboard.asterisk.org/r/1187/diff/2/?file=20737#file20737line9292>
> >
> >     We should have an /* XXX - comments */ thing here indicating that it should probably be re-examined later.
> 
> Olle E Johansson wrote:
>     How are you thinking? I can't follow you here.

Eh, I might just need to retract that ship it in general.  Is there any compelling reason not to make this event an 'Indication' event instead of a Newstate?

The bit about /* XXX  comments is that we generally use them to indicate something that we know we aren't quite doing in a kosher manner.  In this case, that would have applied.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1187/#review4971
-----------------------------------------------------------


On Sept. 19, 2011, 6:43 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1187/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 6:43 a.m.)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Add a manager event for early media. Using the existing Newstate event with a "faked" state called "progress". 
> 
> In the long run, this is not the right thing to do, but after discussion with Russell on asterisk-dev it was concluded that it was the easiest way forward.
> 
> 
> This addresses bug 19135.
>     https://issues.asterisk.org/jira/browse/19135
> 
> 
> Diffs
> -----
> 
>   /team/oej/bring-in-the-early-media-trunk/apps/app_dial.c 332755 
>   /team/oej/bring-in-the-early-media-trunk/main/pbx.c 332755 
> 
> Diff: https://reviewboard.asterisk.org/r/1187/diff
> 
> 
> Testing
> -------
> 
> Tested many calls in the 1.4 version of the same patch. 
> 
> One-legged calls using the progress() dialplan app, two legged calls using dial().
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/7ff51a7d/attachment.htm>