[asterisk-dev] [Code Review] Regression: Fix behavior of queue set penalty so that it properly handles 'queue set penalty <penalty> on <interface>' instead of crashing caused by r325483

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1609/
-----------------------------------------------------------

(Updated Dec. 8, 2011, 10:56 a.m.)


Review request for Asterisk Developers and irroot.


Changes
-------

Pulls actual member setting behavior into a helper function.
Unifies behavior so that queue set penalties will be able to set all members on an interface against all queues regardless of whether it's realtime or .conf based.

I've tested it with regular members on regular queues, realtime members on realtime queues, and even realtime members on regular queues. I'd try regular members on realtime queues, but I'm pretty sure that's not a thing.

Of course, using the 'in <queuename>' at the end still works since it just does the same thing it was doing before in that case.


Summary
-------

r325483 caused Asterisk to lose the ability to set penalty on an interface without specifying the queue, and worse than that also introduces a segfault from trying to.  The segfault only occurs when penalty is set using the queue set penalty command in CLI and not when using QueuePenalty from the manager, however the manager action wouldn't work without specifying a queue either, it just wouldn't crash Asterisk.

This patch attempts to fix that by changing irroot's realtime patch so that the new method for picking the queue being acted on is only employed if the method used prior to that can't find a queue to work on.  If no queuename is specified, this is fine since the crash would only occur if there was a queue attached to the interface anyway.  This doesn't seem to cause any problems in normal queues, but I haven't tested it with realtime queues.


Diffs (updated)
-----

  /branches/10/apps/app_queue.c 346971 

Diff: https://reviewboard.asterisk.org/r/1609/diff


Testing
-------

Various uses of queue set penalty and QueuePenalty from manager.  Also, I'm currently working on an automated test for this within the Asterisk testsuite.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111208/73082704/attachment.htm>