[asterisk-dev] [Code Review]: Add the install path of astdb2sqlite3 to paths.h to avoid relying on $PATH when doing automatic astdb conversion

Terry Wilson reviewboard at asterisk.org
Wed Dec 7 10:21:02 CST 2011



> On Dec. 7, 2011, 10:06 a.m., Paul Belanger wrote:
> > This still fails:
> > 
> > $ ./contrib/scripts/live_ast configure
> > $ make
> > $ ./contrib/scripts/live_ast install
> > $ ./contrib/scripts/live_ast samples
> > $ cp ~/astdb.old live/var/lib/asterisk/astdb
> > $ ./live/asterisk -vvvvvc
> > 
> > ---
> >   == Parsing '/home/pabelanger/svn/digium/asterisk/testing/10/live/etc/asterisk/asterisk.conf':   == Found
> > /bin/sh: /usr/sbin/astdb2sqlite3: not found
> > [Dec  7 10:55:08] ERROR[12853]: db.c:199 db_open: *** Database conversion failed!
> > ---
> > 
> >

Then there is something wrong with the script because ASTSBINDIR is being set to /usr/sbin when it clearly isn't.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1613/#review4952
-----------------------------------------------------------


On Dec. 6, 2011, 9:16 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1613/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 9:16 p.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Before patch: Asterisk relies on $PATH to execute astdb2sqlite3 for astdb conversion
> After patch: It doesn't
> 
> 
> This addresses bug ASTERISK-18959.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18959
> 
> 
> Diffs
> -----
> 
>   /branches/10/Makefile 347057 
>   /branches/10/build_tools/make_defaults_h 347057 
>   /branches/10/include/asterisk/paths.h 347057 
>   /branches/10/main/asterisk.c 347057 
>   /branches/10/main/db.c 347057 
> 
> Diff: https://reviewboard.asterisk.org/r/1613/diff
> 
> 
> Testing
> -------
> 
> Delete astdb.sqlite3. Run Asterisk. astdb.sqlite3 exists. No errors.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111207/aff219dc/attachment.htm>


More information about the asterisk-dev mailing list