[asterisk-dev] [Code Review] Queue Tests: Queue Set Penalty command and QueuePenalty ami action.

jrose reviewboard at asterisk.org
Tue Dec 6 13:35:32 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1611/
-----------------------------------------------------------

Review request for Asterisk Developers, Paul Belanger and mjordan.


Summary
-------

This test will attempt to do a few a few queue penalty changing operations, including those addressed in https://reviewboard.asterisk.org/r/1609/

Currently, this test will fail.  If I haven't committed a patch that fixes this problem by the time I can actually commit this test, I'll add the failure expectation flag of course.  But knowing my luck with new tests, I wouldn't be at all surprised if this has to go through a few more revisions before it gets accepted into the test suite anyway, so I'll leave that out for now.

This test has been made in a way such that adding extra related subtests should be a fairly trivial matter.


Diffs
-----

  /asterisk/trunk/tests/queues/set_penalty/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/set_penalty/run-test PRE-CREATION 
  /asterisk/trunk/tests/queues/set_penalty/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/queues/tests.yaml 2868 

Diff: https://reviewboard.asterisk.org/r/1611/diff


Testing
-------

Ran the test, tweaked the test to see that the success condition flags work properly.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111206/89dc9816/attachment-0001.htm>


More information about the asterisk-dev mailing list