[asterisk-dev] [Code Review] Doubly linked lists unit test and update to implementation.

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1569/#review4937
-----------------------------------------------------------

Ship it!


Looks good!

- mjordan


On Nov. 23, 2011, 1:50 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1569/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 1:50 p.m.)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> Update the doubly linked list implementation.  Now safe traversing can insert before and after the current node when traversing in either direction.
> 
> Updated the linked lists unit test test_linkedlist to also test doubly linked lists.  The old test_dlinkedlist requires a manual check of results and probably should be removed.
> 
> Asterisk currently only uses a small subset of the doubly linked lists macro implementation.  It only uses doubly linked lists for the event subscriptions module.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/dlinkedlists.h 346143 
>   /trunk/tests/test_linkedlists.c 346143 
> 
> Diff: https://reviewboard.asterisk.org/r/1569/diff
> 
> 
> Testing
> -------
> 
> Old and new unit tests pass.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111206/56bfd629/attachment.htm>