[asterisk-dev] [Code Review] SIP TLS Registration Test

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1548/
-----------------------------------------------------------

(Updated Dec. 2, 2011, 12:25 p.m.)


Review request for Asterisk Developers, Paul Belanger, opticron, and mjordan.


Changes
-------

Addresses mjordan's last review and also makes use of changes to testsuite to allow use of test directories before starting Asterisk (so tls certs can be properly placed in the folders belonging to the specific asterisk instance using them)


Summary
-------

test: channels/SIP/sip_tls_register

Works in a similar way to sip_register, but uses TLS (which means it has to manage certificate files) and it also uses the TestCase class as well to simplify things.

I made a few changes the other day to get sip_register working normally under my dev machines, and that went fine, but I left the skip option on for it because it mentioned something about failing under FreeBSD, which would imply to me that there is some other reason they were explicitly failing under FreeBSD.  If that's the case, this test also will probably fail under FreeBSD since it makes use of basically all the same library functions as the regular sip_register test.  I'd like some advice on checking whether this failure is still a problem.

There is also some copying of files that goes on to put relevant keys into the working directory, which if ran from the test suite directory means these keys will be placed in the main testsuite folder.  I'm not sure if I should be doing this (I do clean the files up afterwards, but it's rather awkward) or changing my working directory instead and simply set aside a folder for these files to already be accessible from in the first place.


Diffs (updated)
-----

  /asterisk/trunk/lib/python/asterisk/utils.py 2826 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/ca.cfg PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/ca.crt PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/ca.key PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.crt PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.csr PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.key PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.pem PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.crt PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.csr PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.key PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.pem PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/tmp.cfg PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/sip_helper_template.inc PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/sipp/register.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/tests.yaml 2826 

Diff: https://reviewboard.asterisk.org/r/1548/diff


Testing
-------

I made sure the test passes and that the log messages show that the SIP dialog is happening as what would be expected.  In both cases, this test seems to do what it's supposed to do.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111202/a35537ec/attachment-0001.htm>