[asterisk-dev] [Code Review] create testsuite tests for r1533

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1606/#review4902
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/modules.conf
<https://reviewboard.asterisk.org/r/1606/#comment9168>

    This file can be deleted.  The test should use the defaults.



/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1606/#comment9171>

    make sure to set bindaddr=127.0.0.1



/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test
<https://reviewboard.asterisk.org/r/1606/#comment9172>

    remove?



/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test
<https://reviewboard.asterisk.org/r/1606/#comment9173>

    This should not be needed



/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test
<https://reviewboard.asterisk.org/r/1606/#comment9169>

    blob



/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test
<https://reviewboard.asterisk.org/r/1606/#comment9170>

    Make sure you also call TestCase.ami_connect(..) here.


- Paul


On Dec. 1, 2011, 4:07 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1606/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2011, 4:07 p.m.)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> Created a test suite for the REGISTER problems of r1533:
> 
> 
> SCENARIO_TABLE = (
>     ('USER',    'SECRET',       'USERADDR',                 'RESP'),
> 
>     ('baduser', 'badsecret',    'baduser at mydom.com',        403), # authreject
>     ('baduser', 'badsecret',    'baduser at 127.0.0.1',        403), # bad both
> 
>     ('someuser', 'somesecret',  'someuser at mydom.com',       200), # ok
>     ('someuser', 'badsecret',   'someuser at mydom.com',       403), # bad pass
>     ('someuser', 'somesecret',  'someuser at mydom2.com',      200), # ok
>     ('someuser', 'somesecret',  'someuser at mydom3.com',      403), # bad domain
>     ('someuser', 'somesecret',  'someuser@',                404), # bad sip
>     ('someuser', 'somesecret',  '@someuser',                403), # bad dom/sip
> 
>     ('mydom.com', 'mysecret',   'mydom.com at mydom.com',      200), # ok
>     ('mydom.com', 'mysecret',   'mydom.com at mydom2.com',     200), # ok
>     ('mydom.com', 'mysecret',   'mydom.com',                200), # ok(!)
>     ('mydom.com', 'mysecret',   'mydom.com@',               404), # not ok
>     #('mydom.com', 'mysecret',   '@mydom.com',               200), # ok(BAH!)
> )
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/sipp.py 2817 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/modules.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg200.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg403.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg404.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 2817 
> 
> Diff: https://reviewboard.asterisk.org/r/1606/diff
> 
> 
> Testing
> -------
> 
> Before applying r1533:
>   7 errors
> After:
>   0 errors
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111201/f30f3a58/attachment-0001.htm>