[asterisk-dev] [Code Review] Add app_v110 to accept v.110 data calls

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1394/#review4183
-----------------------------------------------------------


Simple peer review


/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8232>

    Comments should be doxygen style when ever possible



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8233>

    It would be nice to see doxygen comments for all functions in your application.



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8225>

    ast_debug()



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8226>

    ast_debug()



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8227>

    ast_debug()



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8228>

    ast_debug()



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8229>

    braces {}



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8230>

    remove space between ( (



/trunk/apps/app_v110.c
<https://reviewboard.asterisk.org/r/1394/#comment8231>

    remove space between ( (


- Paul


On Aug. 26, 2011, 7:19 p.m., dwmw2 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1394/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 7:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a new application app_v110 which accepts data calls from a GSM mobile phone.
> 
> 
> This addresses bug ASTERISK-14185.
>     https://issues.asterisk.org/jira/browse/ASTERISK-14185
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 333428 
>   /trunk/apps/app_v110.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1394/diff
> 
> 
> Testing
> -------
> 
> Asterisk 1.8.5.0+app_v110, ISDN BRI on British Telecom, Nokia N97 GSM phone...
> 
> AT+CBST=71,0,1
> OK
> ATD01799xxxxxx
> CONNECT
> Fedora release 15 (Lovelock)
> Kernel 2.6.40.3-0.fc15.i686 on an i686 (/dev/pts/34)
> 
> obelisk.infradead.org login: dwmw2
> Password: 
> Last login: Sat Aug 27 01:02:52 2011 from 07976xxxxxx
> [dwmw2 at obelisk ~]$ 
> 
> 
> Thanks,
> 
> dwmw2
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110830/791b50e3/attachment-0001.htm>