[asterisk-dev] [Code Review]: Add app_v110 to accept v.110 data calls

[Mark Michelson]

> On Aug. 29, 2011, 9:37 a.m., mjordan wrote:
> > /trunk/apps/app_v110.c, line 646
> > <https://reviewboard.asterisk.org/r/1394/diff/1/?file=19511#file19511line646>
> >
> >     Per the coding standard, variable declarations should be at the beginning of the method (2.3).  Provide the type 'int' as well.

Actually, this is allowed by the coding guidelines, since the declaration is at the beginning of the for loop's scope.

The guideline you are thinking of states that variables shouldn't be declared "mid-block." In other words, no mixed declarations and code. Since this declaration is at the top of the scope, it's fine.


> On Aug. 29, 2011, 9:37 a.m., mjordan wrote:
> > /trunk/apps/app_v110.c, line 593
> > <https://reviewboard.asterisk.org/r/1394/diff/1/?file=19511#file19511line593>
> >
> >     Per the coding standard, variable declarations should be at the beginning of the method (2.3)

Actually, this is allowed by the coding guidelines, since the declaration is at the beginning of the for loop's scope.

The guideline you are thinking of states that variables shouldn't be declared "mid-block." In other words, no mixed declarations and code. Since this declaration is at the top of the scope, it's fine.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1394/#review4155
-----------------------------------------------------------


On Aug. 26, 2011, 7:19 p.m., dwmw2 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1394/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 7:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a new application app_v110 which accepts data calls from a GSM mobile phone.
> 
> 
> This addresses bug ASTERISK-14185.
>     https://issues.asterisk.org/jira/browse/ASTERISK-14185
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 333428 
>   /trunk/apps/app_v110.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1394/diff
> 
> 
> Testing
> -------
> 
> Asterisk 1.8.5.0+app_v110, ISDN BRI on British Telecom, Nokia N97 GSM phone...
> 
> AT+CBST=71,0,1
> OK
> ATD01799xxxxxx
> CONNECT
> Fedora release 15 (Lovelock)
> Kernel 2.6.40.3-0.fc15.i686 on an i686 (/dev/pts/34)
> 
> obelisk.infradead.org login: dwmw2
> Password: 
> Last login: Sat Aug 27 01:02:52 2011 from 07976xxxxxx
> [dwmw2 at obelisk ~]$ 
> 
> 
> Thanks,
> 
> dwmw2
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110830/da79affa/attachment.htm>