[asterisk-dev] [Code Review] TestSuite logging addition

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1382/
-----------------------------------------------------------

(Updated Aug. 26, 2011, 4:24 p.m.)


Review request for Asterisk Developers and Paul Belanger.


Changes
-------

Updated to produce single log file(s) for all test runs.  A messages.log and full.log are created, set at INFO / DEBUG respectively.  A RollingFileHandler is used, with a 6MB limit set to roll at 5 / 10 files.


Summary
-------

Pulled out the logging functionality from review 1380 (https://reviewboard.asterisk.org/r/1380/).  That review will be updated once this review is completed.

This review adds Python logging to the test suite.  The Python libraries were updated to use this.  Note that runtests.py now creates a log file log-console-output.txt to not conflict with the Python log created by TestCase.


Diffs (updated)
-----

  /asterisk/trunk/asttest/asttest.c 1983 
  /asterisk/trunk/lib/python/asterisk/TestCase.py 1983 
  /asterisk/trunk/lib/python/asterisk/ami.py 1983 
  /asterisk/trunk/lib/python/asterisk/asterisk.py 1983 
  /asterisk/trunk/lib/python/asterisk/cdr.py 1983 
  /asterisk/trunk/lib/python/asterisk/config.py 1983 
  /asterisk/trunk/lib/python/asterisk/sipp.py 1983 
  /asterisk/trunk/lib/python/asterisk/version.py 1983 
  /asterisk/trunk/lib/python/asterisk/voicemail.py 1983 
  /asterisk/trunk/lib/python/client.py 1983 
  /asterisk/trunk/logger.conf PRE-CREATION 
  /asterisk/trunk/runtests.py 1983 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf 1983 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test 1983 
  /asterisk/trunk/tests/apps/voicemail/tests.yaml 1983 

Diff: https://reviewboard.asterisk.org/r/1382/diff


Testing
-------

Python logging was used in all of the new VoiceMailMain tests, on review at https://reviewboard.asterisk.org/r/1380/.  Tested with a variety of log levels, including DEBUG, INFO, WARN, and ERROR.


Thanks,

mjordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110826/a063ad9f/attachment.htm>