[asterisk-dev] [Code Review] testsuite: SIP TLS Registration Test

mjordan reviewboard at asterisk.org
Thu Aug 25 14:10:51 CDT 2011 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1317/#review4132
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8091>

    Why did you modify sip_tls_call?  Should this be in sip_tls_register?



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1317/#comment8098>

    Tab in n, steps.  May want to use same => notation as well.



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1317/#comment8099>

    This extension may not be needed.  If AST[2] handles the registration request, the test has already failed and there may not be a need to spawn the originate.



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8100>

    Remove



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8101>

    Probably could remove this.  I know it was copied over from sip_tls_call, but if there is going to be a failed authentication test, it should probably be its own separate test and not part of this test.



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/extensions.conf
<https://reviewboard.asterisk.org/r/1317/#comment8102>

    Tab in n, steps, use same =>



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8103>

    Remove



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8104>

    Remove



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/extensions.conf
<https://reviewboard.asterisk.org/r/1317/#comment8105>

    Tab in, same =>



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8106>

    Remove



/asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/sip.conf
<https://reviewboard.asterisk.org/r/1317/#comment8107>

    Remove



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8088>

    This function now exists in this test, as well as (at a minimum) sip_tls_call.  Should this be migrated to the utils?



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8086>

    * Red blob
    * space needed between for and AST[1]



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8087>

    Red



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8092>

    If this code isn't used, remove it



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8093>

    This method doesn't appear to be used



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8089>

    Blob



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8090>

    Blobs.  Probably don't need 3 lines here to seperate the logic as well.



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8094>

    Remove commented out code



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8095>

    Put a callback handler here in case your originate fails.  In the callback handler, make sure the test fails gracefully.



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8096>

    If you see this condition and the test has failed, why spawn the originate?



/asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test
<https://reviewboard.asterisk.org/r/1317/#comment8097>

    If this originate is still needed, then put a callback handler here in case your originate fails.  In the callback handler, make sure the test fails gracefully.


- mjordan


On July 13, 2011, 11:49 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1317/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 11:49 a.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Test for TLS SIP registration. It's probably still a little rough, but I think it's working fairly well.
> 
> It's based off of the call test and in fact performs much of what is in that test during the test, but obviously some additions were needed in order to test registration.  Registration attempts are made from one Asterisk instance to two others, one of which is intended to succeed and the other intended to fail.  AMI is used to determine the results of those actions.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/sip.conf 1716 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast1/sip_helper.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast2/sip_helper.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/ast3/sip_helper.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/helper1 PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/helper2 PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/helper3 PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/ca.cfg PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/ca.crt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/ca.key PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.crt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.csr PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.key PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverA.pem PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.crt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.csr PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.key PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/serverB.pem PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/configs/keys/tmp.cfg PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_register/test-output.txt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 1716 
> 
> Diff: https://reviewboard.asterisk.org/r/1317/diff
> 
> 
> Testing
> -------
> 
> Tested for registration with bad passwords, tested what would happen if no registration was made, tested registration to the wrong IPs, basically just tested a lot of different scenarios for registration.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110825/57797d15/attachment-0001.htm>

More information about the asterisk-dev mailing list