[asterisk-dev] [Code Review] Some cleanups for the recently commited T38 Gw timeout option

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1385/
-----------------------------------------------------------

(Updated Aug. 26, 2011, 5:36 a.m.)


Review request for Asterisk Developers and Matthew Nicholson.


Changes
-------

checking the gateway_timeout should not be done when reserving a session this will lead to bad karma in the next 10 lives.
the gateway_timeout is set when the details are allocated and must not be overwritten except by FAXOPT(gwtimeout).
checking gateway_timeout should not be done when calling ast_tvnow this introduces inconstancy and confusion.
only check gateway_timeout when possibly removing the framehook on a timeout.


Summary
-------

Recent Changes to res_fax.c to support configurable timeout is not optimal here is a fixup.


Diffs (updated)
-----

  /branches/10/res/res_fax.c 333337 

Diff: https://reviewboard.asterisk.org/r/1385/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110826/a06ef7f0/attachment.htm>