[asterisk-dev] [Code Review] Bug fixes for voicemail user emailsubject / emailbody

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1374/
-----------------------------------------------------------

(Updated Aug. 25, 2011, 4:55 p.m.)


Review request for Asterisk Developers and kmoore.


Changes
-------

Although this already received a ship it, the attached diff addresses the last point rmudgett made.

All unit tests were rerun and passed under valgrind with no memory issues attributed to app_voicemail.  Voicemail was reloaded several times to attempt to cause any issues with the find_user routine.  Note that the unit tests call find_user, but with and without a passed in vmu user struct, which should exercise both the deep and shallow copy.

Also compiled with IMAP support - no unit tests run as IMAP cannot work with dev-mode currently; however, voicemail reloading was done to check find_user modifications.


Summary
-------

This code change fixes two bugs:
ASTERISK-16795
ASTERISK-16781

ASTERISK-16795 was previously fixed in the last iteration and patched to 1.8 and trunk.  Unfortunately, a subsequent check-in blew out the change, removing it from 10 and trunk (10 being subsequently branched off of what was, at the time, trunk).  The previous fix for ASTERISK-16795 resolved most of ASTERISK-16781 - this code change fixes the rest of ASTERISK-16781 by applying escape options to all places voicemail user options are parsed out.

In order to complete this, the relevant code change in apply_options_full will be ported back to 1.8; the rest of these code changes are already in that branch.


This addresses bugs ASTERISK-16781 and ASTERISK-16795;.
    https://issues.asterisk.org/jira/browse/ASTERISK-16781
    https://issues.asterisk.org/jira/browse/ASTERISK-16795;


Diffs (updated)
-----

  /branches/10/apps/app_voicemail.c 333332 

Diff: https://reviewboard.asterisk.org/r/1374/diff


Testing
-------

vmuser unit test updated and ran successfully.


Thanks,

mjordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110825/596e4463/attachment.htm>