[asterisk-dev] [Code Review] res_musiconhold misude of refs

[kobaz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1384/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

When starting MusicOnHold from Dial() there are some unref problems which lead to corruptions and crashing.  See ASTERISK-18346 for more.

This patch makes it so that there isn't an extra unref.  Usually local_ast_moh_cleanup() is called on hangup, but the music is already stopped and cleaned up.  This change prevents local_ast_moh_cleanup() from re-cleaning.


This addresses bug ASTERISK-18346.
    https://issues.asterisk.org/jira/browse/ASTERISK-18346


Diffs
-----

  branches/1.8/res/res_musiconhold.c 333332 

Diff: https://reviewboard.asterisk.org/r/1384/diff


Testing
-------

Dial(SIP/2604)
Pickup
Hold
Unhold
Hangup


Dial(SIP/2604)
Pickup
Hold
Hangup


Dial(SIP/2604,,m(ring))
Pickup
Hangup


Dial(SIP/2604,,m(ring))
Pickup
Hold
Unhold
Hangup


Dial(SIP/2604,,m(ring))
Pickup
Hold
Hangup


Thanks,

kobaz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110825/88922df2/attachment.htm>