[asterisk-dev] [Code Review]: Bug fixes for voicemail user emailsubject / emailbody

[mjordan]

> On Aug. 24, 2011, 2:15 p.m., rmudgett wrote:
> > /branches/10/apps/app_voicemail.c, lines 1725-1732
> > <https://reviewboard.asterisk.org/r/1374/diff/1/?file=18510#file18510line1725>
> >
> >     The if NULL tests are not needed since ast_free will accept a NULL pointer.
> >     
> >     There are several other places in this file doing this as well.
> >     
> >     This is a cleanup that can be done in another patch.

Agreed, but since you caught it might as well fix it now.


> On Aug. 24, 2011, 2:15 p.m., rmudgett wrote:
> > /branches/10/apps/app_voicemail.c, lines 11640-11658
> > <https://reviewboard.asterisk.org/r/1374/diff/1/?file=18510#file18510line11640>
> >
> >     There should be a case for '\\'.  Otherwise substitute_escape() will not allow the user to use \ in the string contents.
> >     
> >     This is not part of the issues being fixed, but it should be fixed.

Added to this and the unit test.


> On Aug. 24, 2011, 2:15 p.m., rmudgett wrote:
> > /branches/10/apps/app_voicemail.c, lines 12331-12342
> > <https://reviewboard.asterisk.org/r/1374/diff/1/?file=18510#file18510line12331>
> >
> >     Shouldn't emailsubject and pagersubject also be graced with substitue_escapes() here?

You'd think so... I'll add them as well.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1374/#review4121
-----------------------------------------------------------


On Aug. 18, 2011, 3:31 p.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1374/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 3:31 p.m.)
> 
> 
> Review request for Asterisk Developers and kmoore.
> 
> 
> Summary
> -------
> 
> This code change fixes two bugs:
> ASTERISK-16795
> ASTERISK-16781
> 
> ASTERISK-16795 was previously fixed in the last iteration and patched to 1.8 and trunk.  Unfortunately, a subsequent check-in blew out the change, removing it from 10 and trunk (10 being subsequently branched off of what was, at the time, trunk).  The previous fix for ASTERISK-16795 resolved most of ASTERISK-16781 - this code change fixes the rest of ASTERISK-16781 by applying escape options to all places voicemail user options are parsed out.
> 
> In order to complete this, the relevant code change in apply_options_full will be ported back to 1.8; the rest of these code changes are already in that branch.
> 
> 
> This addresses bugs ASTERISK-16781 and ASTERISK-16795;.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16781
>     https://issues.asterisk.org/jira/browse/ASTERISK-16795;
> 
> 
> Diffs
> -----
> 
>   /branches/10/apps/app_voicemail.c 332504 
> 
> Diff: https://reviewboard.asterisk.org/r/1374/diff
> 
> 
> Testing
> -------
> 
> vmuser unit test updated and ran successfully.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110824/8a53efe4/attachment-0001.htm>