[asterisk-dev] [Code Review] Bug fixes for voicemail user emailsubject / emailbody
mjordan
reviewboard at asterisk.org
Wed Aug 24 14:56:18 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1374/
-----------------------------------------------------------
(Updated Aug. 24, 2011, 2:56 p.m.)
Review request for Asterisk Developers and kmoore.
Changes
-------
Fixed memory leaks per rmudgett, added consistency in escape_sequences and other apply option areas for emailsubject, pagersubject. Updated unit test and retested.
Summary
-------
This code change fixes two bugs:
ASTERISK-16795
ASTERISK-16781
ASTERISK-16795 was previously fixed in the last iteration and patched to 1.8 and trunk. Unfortunately, a subsequent check-in blew out the change, removing it from 10 and trunk (10 being subsequently branched off of what was, at the time, trunk). The previous fix for ASTERISK-16795 resolved most of ASTERISK-16781 - this code change fixes the rest of ASTERISK-16781 by applying escape options to all places voicemail user options are parsed out.
In order to complete this, the relevant code change in apply_options_full will be ported back to 1.8; the rest of these code changes are already in that branch.
This addresses bugs ASTERISK-16781 and ASTERISK-16795;.
https://issues.asterisk.org/jira/browse/ASTERISK-16781
https://issues.asterisk.org/jira/browse/ASTERISK-16795;
Diffs (updated)
-----
/branches/10/apps/app_voicemail.c 333159
Diff: https://reviewboard.asterisk.org/r/1374/diff
Testing
-------
vmuser unit test updated and ran successfully.
Thanks,
mjordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110824/4b392524/attachment.htm>
More information about the asterisk-dev
mailing list