[asterisk-dev] [Code Review] Make send_text() prefer real-time text if it is available (patch submitted by Emmanuel BUU on JIRA)

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1356/#review4120
-----------------------------------------------------------


If no one has a problem with this change, I'm going to go ahead and commit it tomorrow even without a "Ship It!" since it isn't originally my patch and therefor I just as easily could have reviewed it myself. I just wanted to make sure to give people a chance to comment.

- Terry


On Aug. 9, 2011, 11:27 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1356/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 11:27 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch was submitted by Emmanuel BUU on JIRA. I have just updated it for trunk and done some testing.
> 
> This patch causes the send_text() function (and therefor the SendText dialplan application and other places in the code) to use the write_text() callback to write text frames to the channel instead of using the send_text callback to do a more out-of-band transmission. If text has not been negotiated, or there is no write_text callback, things behave as they always have.
> 
> I am placing this up for review so that there can be some public discussion just to make sure this seems like reasonable behavior to everyone.
> 
> 
> This addresses bug ASTERISK-17937.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17937
> 
> 
> Diffs
> -----
> 
>   /trunk/main/channel.c 331042 
> 
> Diff: https://reviewboard.asterisk.org/r/1356/diff
> 
> 
> Testing
> -------
> 
> I have tested with SIPcon1 and verified that the T.140 text works. I have also tried with a client that didn't support real-time text and saw that SIP MESSAGE requests were sent as they were before.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110824/092d1a0c/attachment.htm>