[asterisk-dev] [Code Review] Fix install paths with spaces.
Jason Parker
reviewboard at asterisk.org
Wed Aug 24 13:08:13 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1379/
-----------------------------------------------------------
Review request for Asterisk Developers and Kevin Fleming.
Summary
-------
All of the iterations thus far have had issues. As far as I'm aware, many of them had to do with the sounds/Makefile.
This removes all of the configure script magic from the previous iteration, and rewrites the logic for sound download/installation (most of which required simplification).
This addresses bug ASTERISK-18290.
https://issues.asterisk.org/jira/browse/ASTERISK-18290
Diffs
-----
branches/1.8/Makefile 333067
branches/1.8/build_tools/mkpkgconfig 333067
branches/1.8/configure UNKNOWN
branches/1.8/configure.ac 333067
branches/1.8/makeopts.in 333067
branches/1.8/sounds/Makefile 333067
Diff: https://reviewboard.asterisk.org/r/1379/diff
Testing
-------
Worksforme. The previous version of this patch with just the sounds/Makefile changes made OS X and Linux work. This one may have issues on OS X because of the configure changes, but I suspect none of it was necessary (or used - due to a typo).
Thanks,
Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110824/e455f920/attachment-0001.htm>
More information about the asterisk-dev
mailing list