[asterisk-dev] [Code Review] Add manager event for local "semi-bridge"

Marquis reviewboard at asterisk.org
Tue Aug 23 10:39:41 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1154/#review4108
-----------------------------------------------------------

Ship it!


Other than the red which lathama already mentioned, this looks good to me.

- Marquis


On March 30, 2011, 10:05 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1154/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 10:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When the local channel "bridges" two channels there's no event similar to the "Bridge" event in the core brdige. This makes it hard to track channels if you don't start guessing. Also, this event reports the state of the bridge optimization flag "/n".
> 
> 
> This addresses bug 19043.
>     https://issues.asterisk.org/jira/browse/19043
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 311843 
> 
> Diff: https://reviewboard.asterisk.org/r/1154/diff
> 
> 
> Testing
> -------
> 
> Compiled, executed, noticed event, made AMI developer happy, did not get beer. Yet. more patches to come I guess.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110823/db53b893/attachment.htm>


More information about the asterisk-dev mailing list