[asterisk-dev] [Code Review] Add the ability to parse RC and BETA in an Asterisk version.

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1375/#review4104
-----------------------------------------------------------

Ship it!


Looks to make sense, and unit tests were updated to address original concerns.  I think if we find ourselves going any further than "99999999999", we may want to find an alternate way of comparing version numbers, but that's just me.

- mjordan


On Aug. 19, 2011, 9:11 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1375/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2011, 9:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to parse Asterisk 1.8.6.0-rc1 properly in the testsuite.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/version.py 1867 
> 
> Diff: https://reviewboard.asterisk.org/r/1375/diff
> 
> 
> Testing
> -------
> 
> unit tests
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110822/26078c47/attachment.htm>