[asterisk-dev] [Code Review]: Add the ability to parse RC and BETA in an Asterisk version.

[Paul Belanger]

> On Aug. 18, 2011, 4:18 p.m., Shaun Ruffell wrote:
> > asterisk/trunk/lib/python/asterisk/version.py, lines 111-127
> > <https://reviewboard.asterisk.org/r/1375/diff/1/?file=18511#file18511line111>
> >
> >     I think subtracting the weights like this isn't completely safe:
> >     
> >     The following test will fail:
> >     
> >         def test_cmp19(self):
> >             v1 = AsteriskVersion("1.8.6.1")
> >             v2 = AsteriskVersion("1.8.6.0-rc11")
> >             self.assertTrue(v1 > v2)
> >

Ya, I figured subtracting the values would cause an issue.  I couldn't figure out the pattern.  I've been banging my head against the keyboard of the last few hours trying to fix it.  Going to take a break for a bit and see if I can figure it out.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1375/#review4089
-----------------------------------------------------------


On Aug. 18, 2011, 3:42 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1375/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 3:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to parse Asterisk 1.8.6.0-rc1 properly in the testsuite.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/version.py 1867 
> 
> Diff: https://reviewboard.asterisk.org/r/1375/diff
> 
> 
> Testing
> -------
> 
> unit tests
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110818/a25dab80/attachment.htm>