[asterisk-dev] [Code Review]: Add the ability to define asterisk module dependencies from a test.

[mjordan]

> On Aug. 16, 2011, 7:10 p.m., mjordan wrote:
> >
> 
> Russell Bryant wrote:
>     Um, I posted this review.  Why I was logged in as mjordan is a mystery to me.  How incredibly bizarre...
> 
> Russell Bryant wrote:
>     The only thing I can think of is that the last time I used reviewboard on this laptop could have been back when I manually created mjordan's account, so it must be related to that.

I was totally wondering how I clicked the ship it button... 


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1366/#review4076
-----------------------------------------------------------


On Aug. 16, 2011, 4:10 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1366/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2011, 4:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Our tests blindly assume the host machine has the required modules for a test, this is not always the case.  So, I've added a simple dependency check for a test writer to define which asterisk modules their test requires.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/runtests.py 1857 
>   asterisk/trunk/tests/pbx/pbx_lua_background/test-config.yaml 1857 
> 
> Diff: https://reviewboard.asterisk.org/r/1366/diff
> 
> 
> Testing
> -------
> 
> local development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110817/dc5cee8b/attachment.htm>