[asterisk-dev] [Code Review] Additional tests for app_voicemail

Fri Aug 12 09:00:37 CDT 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1360/
-----------------------------------------------------------

(Updated Aug. 12, 2011, 9 a.m.)

Review request for Asterisk Developers and Paul Belanger.

Changes
-------

Updated diff per jrose's request; has a few changes to the extensions.conf per my findings.  Tests are now out on a team branch as well.

Summary
-------

The following tests for are for the following app_voicemail applications:
  VoiceMail - checking extension routing, priority message leaving, message forwarding, and external notifications
  VMCOUNT - function that uses several app_voicemail methods for counting inbox messages
  VMAuthenticate - mailbox / password authentication

Features that are covered by these tests are documented at https://wiki.asterisk.org/wiki/display/~mjordan/Voicemail+Refactoring - although this is a draft document and should not be taken as cannon.

Note that currently, leave_voicemail_contexts, leave_voicemail_forwarding, and leave_voicemail_forwarding_auto_urgent are expected to fail and are noted as such with the ASTERISK bugs that were filed.

Diffs (updated)
-----

  /asterisk/trunk/runtests.py 1833 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_extensions/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/authenticate_nominal/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/func_vmcount/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/func_vmcount/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/func_vmcount/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/func_vmcount/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/func_vmcount/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/extern-notify-script.py PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast1/voicemail.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast2/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast2/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/configs/ast2/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/run-test PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/voicemail/tests.yaml 1833 

Diff: https://reviewboard.asterisk.org/r/1360/diff

Testing
-------

Thanks,

mjordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110812/722a9778/attachment.htm>