[asterisk-dev] [Code Review] Fix multiple parking issues.

Kevin P. Fleming kpfleming at digium.com
Thu Aug 11 11:39:53 CDT 2011


On 08/11/2011 10:25 AM, Shaun Ruffell wrote:
> On Thu, Aug 11, 2011 at 02:28:40PM -0000, jrose wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviewboard.asterisk.org/r/1358/#review4032
>> -----------------------------------------------------------
>>
>>
>> Honestly, patches this huge are very difficult to track with
>> reviewboard, and in fact I don't really believe there is a diff viewer
>> on Earth that could adequately portray something with this much
>> reordering...
>
> Hopefully in the not-too-distant future we will have a good way to
> handle patch series instead of individual patches. A side effect of
> taking large groups of related, but independent, commits as patch series
> is ease of bisecting for regressions after the fact.
>
> Looking at the description in https://reviewboard.asterisk.org/r/1358
> leads me to believe this change is a prime candidate.

We already do, and we're testing it. Crucible can handle reviews from 
branches without collapsing all the revisions into a single diff (unless 
you want it to), and I believe it can also handle uploading multiple 
patches into a single review (although I don't think any of us have 
tested that).

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
Jabber: kfleming at digium.com | SIP: kpfleming at digium.com | Skype: kpfleming
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at www.digium.com & www.asterisk.org



More information about the asterisk-dev mailing list