[asterisk-dev] [Code Review] Make CONFBRIDGE_INFO behave more nicely

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1359/#review4036
-----------------------------------------------------------



trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1359/#comment7940>

    I don't think you need this (and it certainly doesn't need to be an ERROR). I think if you wanted to keep this, change it to NOTICE and not ERROR.



trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1359/#comment7941>

    Same as above -- no need to make this an ERROR -- NOTICE would be better.


- Leif


On Aug. 11, 2011, 10:41 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1359/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2011, 10:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> As introduced for Asterisk 10 and trunk, CONFBRIDGE_INFO doesn't behave as nicely in edge cases as MEETME_INFO.  With this patch, CONFBRIDGE_INFO should behave in a much more reasonable manner when presented with invalid conferences and keywords.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 331518 
> 
> Diff: https://reviewboard.asterisk.org/r/1359/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110811/15ab177d/attachment-0001.htm>