[asterisk-dev] [Code Review] SIP Notify via AMI or CLI leaks SIP PVTs

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1332/#review4027
-----------------------------------------------------------

Ship it!


Nice catch! That was some backwards looking code there.

- David


On July 28, 2011, 1:15 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1332/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 1:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Any SIP notify sent via AMI or CLI leaks a SIP PVT with ref count +2.  This seems to have occurred when or before transmit_sip_request was replaced by other functions.  Removing the additional ref just before the invite and adding an unref following it corrects the issue as seen via REF_DEBUG.  The unref existed in a distant revision and it appears as though the wrong ref operation was removed.
> 
> 
> This addresses bug ASTERISK-18091.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18091
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 329610 
> 
> Diff: https://reviewboard.asterisk.org/r/1332/diff
> 
> 
> Testing
> -------
> 
> Reproduced the leak and made sure the leak no longer occurred with the change.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110810/711eb55f/attachment.htm>