[asterisk-dev] [Code Review] Initial tests for app_voicemail

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1354/#review4022
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7926>

    This could be simpler with tuple interpolation instead of mapping into a dict since it's a single value like so:
    msgName = 'msg%04d' % (msgnum)
    
    This is more a matter style than anything else, so feel free to ignore it.



/asterisk/trunk/lib/python/asterisk/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7927>

    Ditto.



/asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/1354/#comment7925>

    The return code of run-test is not limited by the framework to be 0 or 1 (although it appears this is the case in practice).  README.txt states that any non-zero must be considered failure.


- opticron


On Aug. 10, 2011, 2:09 p.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1354/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 2:09 p.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Added initial test for app_voicemail.  This just tests the nominal path for dialplan function VoiceMail().
> 
> Additional tests will be added for the rest of the dialplan applications and their features.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 1803 
>   /asterisk/trunk/lib/python/asterisk/voicemail.py PRE-CREATION 
>   /asterisk/trunk/runtests.py 1803 
>   /asterisk/trunk/tests/apps/tests.yaml 1803 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/voicemail.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/sounds/talking.ulaw PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/tests.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1354/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110810/c24c5661/attachment-0001.htm>