[asterisk-dev] [Code Review] Initial tests for app_voicemail

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1354/#review4019
-----------------------------------------------------------


This look real good!  A first pass with some comments.  Expect a few more once I get your test running.


/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1354/#comment7908>

    minor, but indent these.  Easier to read.



/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/manager.general.conf.inc
<https://reviewboard.asterisk.org/r/1354/#comment7909>

    This can be removed, but bind to 127.0.0.1 by default



/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1354/#comment7910>

    Are you host settings correct for your peers?  Now that you have 2 instances?



/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test
<https://reviewboard.asterisk.org/r/1354/#comment7907>

    You should be able to access this information from the TestCase class.  If not, we can add it.



/asterisk/trunk/tests/apps/voicemail/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7902>

    Might as well move this into lib/python/asterisk since other tests could use it.



/asterisk/trunk/tests/apps/voicemail/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7903>

    We should avoid hard coding asterisk paths, with an Asterisk instance you can access ast1.directories['spooldir'] to read the asterisk.conf value.



/asterisk/trunk/tests/apps/voicemail/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7904>

    If we can avoid hardcoding the path for the test, it would be nice.  Maintenance issue 



/asterisk/trunk/tests/apps/voicemail/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7905>

    blob



/asterisk/trunk/tests/apps/voicemail/voicemail.py
<https://reviewboard.asterisk.org/r/1354/#comment7906>

    only function missing a comment


- Paul


On Aug. 10, 2011, 11:08 a.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1354/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 11:08 a.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Added initial test for app_voicemail.  This just tests the nominal path for dialplan function VoiceMail().
> 
> Additional tests will be added for the rest of the dialplan applications and their features.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 1803 
>   /asterisk/trunk/tests/apps/tests.yaml 1803 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/voicemail.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/sounds/talking.ulaw PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/voicemail/voicemail.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1354/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110810/6f23391f/attachment-0001.htm>