[asterisk-dev] [Review] dahdi-tools: freepbxdb configuration generator

[Russ Meyerriecks]

On Wed, Aug 10, 2011 at 08:09:49PM +0300, Tzafrir Cohen wrote:
> On Wed, Aug 10, 2011 at 11:58:19AM -0500, Shaun Ruffell wrote:
> > On Wed, Aug 10, 2011 at 07:56:27PM +0300, Tzafrir Cohen wrote:
> > > On Wed, Aug 10, 2011 at 11:19:44AM -0500, Russ Meyerriecks wrote:
> > > > On Wed, Aug 10, 2011 at 12:50:27PM +0300, Tzafrir Cohen wrote:
> > > > > This adds another configuration generator for dahdi_genconf:
> > > > > 
> > > > >   dahdi_genconf freepbxdb
> > > > 
> > > > This is really great. My only request is that it doesn't complain if
> > > > asterisk isn't installed like genconf does now.
> > > 
> > > dahdi_genconf is typically run before starting asterisk. This module is
> > > intended to be run separately and optionally. I currently have a
> > > separate option in live_dahdi to run it (just after starting asterisk).
> > > 
> > > It can't really tell that Asterisk is not installed. It can check if the
> > > socket is not there and silently do nothing. Is that what you were
> > > after?
> > 
> > I'm guessing Russ was referring to something like "$dahdi_genconf system"?
> 
> Err... you mean: 'dahdi_genconf chandahdi' (or some others) that fail
> if /etc/asterisk does not exist?

That's correct. I use dahdi_genconf to generate default configurations
for testing out my driver changes. In one case, if /etc/asterisk didn't
exist, it was failing one of my automated testing scripts. Changing it
to "dahdi_genconf system" fixed the problem.

So I suppose, really, my point is moot unless the changes affected a
"dahdi_genconf system", which it doesn't sound like it would.