[asterisk-dev] [Code Review] Testsuite: CDRTestCase and tests/cdr/originate_sip_congestion_log

Tue Aug 9 11:48:16 CDT 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1357/#review4006
-----------------------------------------------------------

This good to be a good start, I've made some first pass comments.  I'll be trying this test in the next hour or so.

/asterisk/trunk/lib/python/asterisk/CDRTestCase.py
<https://reviewboard.asterisk.org/r/1357/#comment7864>

    blob

/asterisk/trunk/lib/python/asterisk/CDRTestCase.py
<https://reviewboard.asterisk.org/r/1357/#comment7862>

    Hard-coded paths should be avoided.  You should be able to access the astlogdir directory from:

    ast1.directories['astlogdir']

/asterisk/trunk/lib/python/asterisk/CDRTestCase.py
<https://reviewboard.asterisk.org/r/1357/#comment7863>

    blob

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast1/manager.conf
<https://reviewboard.asterisk.org/r/1357/#comment7869>

    We should not be over writing the base manager.conf file, you should create a manager.users.conf.inc file for theses settings.

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1357/#comment7870>

    loopback adapter (127.0.0.1)

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast2/cdr.conf
<https://reviewboard.asterisk.org/r/1357/#comment7871>

    This file is broken, no [general] header.

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast2/sip.conf
<https://reviewboard.asterisk.org/r/1357/#comment7872>

    same, 127.0.0.2

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/run-test
<https://reviewboard.asterisk.org/r/1357/#comment7865>

    You don't need to pass any arguments, these should be the defaults.

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/test-config.yaml
<https://reviewboard.asterisk.org/r/1357/#comment7866>

    Why 1.12?

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/test-config.yaml
<https://reviewboard.asterisk.org/r/1357/#comment7867>

    remove

/asterisk/trunk/tests/cdr/originate_sip_congestion_log/test-output.txt
<https://reviewboard.asterisk.org/r/1357/#comment7868>

    Do you still get this traceback?

/asterisk/trunk/tests/manager/event-monitor/configs/ast1/manager.conf
<https://reviewboard.asterisk.org/r/1357/#comment7873>

    same comment as before, don't override this file and use the #include statement.

- Paul

On Aug. 9, 2011, 11:31 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1357/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 11:31 a.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> This is a test suite addition for performing tests involving CDRs.  It should be possible now to perform most of the CDR tests simply by using AMI commands to control the call and have some CDR info supplied before hand and the whole test should just work without much input beyond that.
> 
> The test included which uses the CDRTestCase requires a patch that is still in review from:
> https://reviewboard.asterisk.org/r/1331/
> 
> If this change is OK'd, I'll go ahead and start working on a major conversion project to change most of the existing python CDR tests into CDRTestCase equivalents.
> 
> Note about CDRTestCase - It is a subclass of TestCase, so it has most of the functionality from that.  In addition, it holds CDRLines specific to individual instances of Asterisk that are running and makes adding expected lines and checking them as simple as a single function call containing the CDRLine and an index.  It should also be pretty easy to adapt the behavior for more elaborate needs.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast1/cdr.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast1/manager.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast2/cdr.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/run-test PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/cdr/originate_sip_congestion_log/test-output.txt PRE-CREATION 
>   /asterisk/trunk/tests/cdr/tests.yaml 1822 
>   /asterisk/trunk/tests/manager/event-monitor/configs/ast1/manager.conf 1822 
>   /asterisk/trunk/lib/python/asterisk/CDRTestCase.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1357/diff
> 
> 
> Testing
> -------
> 
> The bulk of the testing was just making sure the add method and the match methods worked properly.  There was also getting the test itself working.  I'm pretty confident that this is fine as is.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110809/d9495f5d/attachment-0001.htm>