[asterisk-dev] [Code Review] Allow empty display name if callerid is set to an empty string. Take 2!

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1341/
-----------------------------------------------------------

(Updated Aug. 3, 2011, 1:42 p.m.)


Review request for Asterisk Developers, David Vossel and rmudgett.


Changes
-------

No longer drops Display Name when chan_sip reverts to default caller id of "asterisk".  Now only drops display name when number is specified without name.
This means the tests that were failing before no longer fail.

Also, changes made similar to what was suggested by rmudgett.


Summary
-------

This is basically what I was trying to do with the user submitted patch from yesterday.  After speaking with Richard, it became somewhat obvious that the approach to the patch had too much extra impact on the SIP messages when all that was really needed was specifically targeting the creation of the display name.

This approach checks strictly for a caller id name and if it isn't there, we skip the creation of the display name.  I think this should be safer in general than the previous approach.


This addresses bug ASTERISK-16198.
    https://issues.asterisk.org/jira/browse/ASTERISK-16198


Diffs (updated)
-----

  /trunk/CHANGES 330571 
  /trunk/channels/chan_sip.c 330571 

Diff: https://reviewboard.asterisk.org/r/1341/diff


Testing
-------

Testing was similar to last time with focus on comparing the SIP messages between this branch and the normal trunk.  In this case, only the display name gets changed.

A few SIP tests from the test suite were also ran successfully.  I haven't ran the full test suite yet, but am preparing to do so.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110803/dc80c7ec/attachment-0001.htm>