[asterisk-dev] [Code Review] If DNS is unavailable at start-up, update peer address so registration works when DNS comes back

[kobaz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1335/#review3982
-----------------------------------------------------------


It looks good overall.  It fixes the problem of lacking dns on startup when registering via a peer.

- kobaz


On Aug. 2, 2011, 10:19 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1335/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 10:19 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If Asterisk starts and no DNS is available, outbound registrations will fail indefinitely. This patch copies the address from the sip_registry struct, which will be updated, to the peer->addr when necessary.
> 
> If dnsmgr is enabled, the registration fails without the patch because even though the address on the registry is updated via dnsmgr, the address is just copied on the first try. Since we use ast_sockaddr_copy, dnsmgr can't update the address that is copied to the sip_pvt or peers.
> 
> 
> This addresses bug ASTERISK-18000.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18000
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 330109 
> 
> Diff: https://reviewboard.asterisk.org/r/1335/diff
> 
> 
> Testing
> -------
> 
> Disable DNS server, load asterisk, watch registration fail. Start DNS server, watch registration succeed. Both with and without dnsmgr tested.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110803/6d8a6982/attachment.htm>