[asterisk-dev] dvossel: trunk r315856 - /trunk/apps/app_confbridge.c

[Russell Bryant]

----- Original Message -----
> In article <E1QF8u4-0004FT-UD at wibble.digium.internal>,
> SVN commits to the Digium repositories <svn-commits at lists.digium.com>
> wrote:
> > Author: dvossel
> > Date: Wed Apr 27 12:51:53 2011
> > New Revision: 315856
> >
> > URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=315856
> > Log:
> > Makes the new ConfBridge join and leave sounds be used by default
> > rather than beep and beeperr.
> >
> > Modified:
> >     trunk/apps/app_confbridge.c
> >
> > Modified: trunk/apps/app_confbridge.c
> > URL:
> > http://svnview.digium.com/svn/asterisk/trunk/apps/app_confbridge.c?view=diff&rev=315856&r1=315855&r2=315856
> > ==============================================================================
> > --- trunk/apps/app_confbridge.c (original)
> > +++ trunk/apps/app_confbridge.c Wed Apr 27 12:51:53 2011
> > @@ -299,9 +299,9 @@
> >  	case CONF_SOUND_ERROR_MENU:
> >  		return S_OR(custom_sounds->errormenu, "conf-errormenu");
> >  	case CONF_SOUND_JOIN:
> > - return S_OR(custom_sounds->join, "beep");
> > + return S_OR(custom_sounds->join, "confbridge-join");
> >  	case CONF_SOUND_LEAVE:
> > - return S_OR(custom_sounds->leave, "beeperr");
> > + return S_OR(custom_sounds->leave, "confbridge-leave");
> >  	}
> 
> A very minor nit to pick, but all the other sounds have conf- as the
> prefix rather than confbridge-, so perhaps conf-join and conf-leave
> might be more consistent...

Good point.  +1 from me.  :-)

-- 
Russell Bryant
Digium, Inc.   |   Engineering Manager, Open Source Software
445 Jan Davis Drive NW    -     Huntsville, AL 35806  -  USA
www.digium.com  -=-  www.asterisk.org -=- blogs.asterisk.org