[asterisk-dev] [Code Review] Changes to h323 to allow use with h323plus > 1.20.

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1117/#review3425
-----------------------------------------------------------


A few comments about formatting.


/trunk/channels/chan_h323.c
<https://reviewboard.asterisk.org/r/1117/#comment7051>

    space before and after =



/trunk/channels/chan_h323.c
<https://reviewboard.asterisk.org/r/1117/#comment7052>

    braces for if statements



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7053>

    Comments should be formated /* */



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7054>

    braces for if statements.  Add space before and after =



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7055>

    if {
       ...
    }



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7056>

    Drop brackets () and add space



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7057>

    same



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7058>

    same


- Paul


On 2011-03-03 06:18:38, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1117/
> -----------------------------------------------------------
> 
> (Updated 2011-03-03 06:18:38)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Changes to h323 to allow use with h323plus > 1.20.
> 
> 
> This addresses bugs 16619 and 18670.
>     https://issues.asterisk.org/view.php?id=16619
>     https://issues.asterisk.org/view.php?id=18670
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_h323.c 309077 
>   /trunk/channels/h323/ast_h323.h 309077 
>   /trunk/channels/h323/ast_h323.cxx 309077 
>   /trunk/channels/h323/chan_h323.h 309077 
>   /trunk/configs/h323.conf.sample 309077 
>   /trunk/configure.ac 309077 
> 
> Diff: https://reviewboard.asterisk.org/r/1117/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110426/53487d0e/attachment-0001.htm>