[asterisk-dev] Final call for changes to Asterisk 1.4 and 1.6.2

[Russell Bryant]

----- Original Message -----
> Thank you Russell.
> 
> 
> Your fix saves other programmer's life, that is fine.

Well it's just that the bug was deeper than func_shell.
 
> But my patch beyonds that, it is efficient ( only call strlen once, no
> strcat ) then the original code, and it also fixs SHELL multiple line
> result breaks AGI parse issue, please check out my diff.

I do agree that some of those changes are good for performance.  However, I don't want to make the change that is replacing \n with \r in the output.  I don't think SHELL() should be touching the output at all.  If the command you are running is causing you some trouble with AGI parsing, then wrap it in something like BASE64_ENCODE(SHELL(...)).

A new patch that only addresses the performance improvements would be fine (but only for trunk).  Also, please check our formatting guidelines.

Thanks,

-- 
Russell Bryant
Digium, Inc.   |   Engineering Manager, Open Source Software
445 Jan Davis Drive NW    -     Huntsville, AL 35806  -  USA
www.digium.com  -=-  www.asterisk.org -=- blogs.asterisk.org