[asterisk-dev] [Code Review] HD ConfBridge application

[David Vossel]

> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 364-365
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line364>
> >
> >     If you are going to make it 1 bit, call it unsigned.

fixed


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 607-616
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line607>
> >
> >     I would rather see the ast_calloc() down with the NULL check to make things a bit more clear

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 650-657
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line650>
> >
> >     eep, don't ast_strdupa() in a loop

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 770-771
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line770>
> >
> >     Having both [] and <> is confusing.  Make it [] for optional, <> for required.

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, line 932
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line932>
> >
> >     ast_copy_string()

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 1199-1201
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line1199>
> >
> >     what about cfg == NULL ?

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 1206-1208
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line1206>
> >
> >     maybe a LOG_WARNING here to note that a section is being ignored

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, line 1253
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line1253>
> >
> >     There are a few different places where memcpy() is used as a deep copy.  It may be worth wrapping this in a user_profile_copy() function like you have for bridge profiles just in case more is needed to do a deep copy at some future point.  If that happens, only one place will need to be changed.

done


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/conf_config_parser.c, lines 1282-1298
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16000#file16000line1282>
> >
> >     bridge_profile_name changes later.  Does this copy_string need to be moved down?  I think so ...

fixed.


> On 2011-04-15 15:00:00, Russell Bryant wrote:
> > /trunk/apps/confbridge/include/confbridge.h, line 178
> > <https://reviewboard.asterisk.org/r/1147/diff/3/?file=16001#file16001line178>
> >
> >     PATH_MAX

done


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1147/#review3381
-----------------------------------------------------------


On 2011-03-28 15:47:43, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1147/
> -----------------------------------------------------------
> 
> (Updated 2011-03-28 15:47:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The new ConfBridge application.  It's kind of a big deal.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/confbridge.conf.sample PRE-CREATION 
>   /trunk/include/asterisk/bridging.h 311748 
>   /trunk/include/asterisk/bridging_features.h 311748 
>   /trunk/include/asterisk/bridging_technology.h 311748 
>   /trunk/include/asterisk/channel.h 311748 
>   /trunk/include/asterisk/dsp.h 311748 
>   /trunk/main/bridging.c 311748 
>   /trunk/main/channel.c 311748 
>   /trunk/main/dsp.c 311748 
>   /trunk/apps/confbridge/include/confbridge.h PRE-CREATION 
>   /trunk/bridges/bridge_builtin_features.c 311748 
>   /trunk/bridges/bridge_softmix.c 311748 
>   /trunk/apps/confbridge/conf_config_parser.c PRE-CREATION 
>   /trunk/apps/app_confbridge.c 311748 
>   /trunk/CHANGES 311748 
>   /trunk/UPGRADE.txt 311748 
>   /trunk/apps/Makefile 311748 
>   /trunk/res/res_musiconhold.c 311748 
> 
> Diff: https://reviewboard.asterisk.org/r/1147/diff
> 
> 
> Testing
> -------
> 
> All confbridge.conf features have been tested.
> Load tested at sample rates ranging from 8-48khz.
> AMI actions/events tested
> CLI commands tested
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110420/7f93651b/attachment-0001.htm>