[asterisk-dev] [Code Review] ast_pickup_call() refactor to create a common core function ast_do_pickup()

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1185/
-----------------------------------------------------------

(Updated 2011-04-21 06:09:52.361990)


Review request for Asterisk Developers.


Changes
-------

features:ast_pickup_call() changes:
  if pickupsounds enabled; answer calling channel and
    a). play successful pickup sound before the actual pickup and masquerade, otherwise the beep is distorted.
  or  
    b). play failed pickup sound, this then lets a SIP caller know. DAHDI callers could already hear the failed beep.

app_directed pickup:pickup_exec() changes:
  to be consistant with the other dialplan pickups where no beeps are heard on fail or not.
  change the call to ast_pickup_call() which does beep, to a new pickup_by_group() which doesn't beep.

The pickupexten feature code ( *8 default ) still does beep if configured.
  
also includes bbryant https://reviewboard.asterisk.org/r/1175/


Summary
-------

debugging mantis 18654, found common code, of which 1 set was wrong, the ast_pickup_call() code in features.c
The actual fault was ast_pickup_call where the target chan was unlocked too early - see bug18654.diff2.txt

Moved app_directed:pickup_do() to features:ast_do_pickup().

Now functions below all now use the new ast_do_pickup()
app_directed_pickup.c:
   pickup_by_channel()
   pickup_by_exten()
   pickup_by_mark()
   pickup_by_part()
features.c:
   ast_pickup_call() 


This addresses bug 18654.
    https://issues.asterisk.org/view.php?id=18654


Diffs (updated)
-----

  trunk/apps/app_directed_pickup.c 314594 
  trunk/channels/chan_sip.c 314594 
  trunk/include/asterisk/features.h 314594 
  trunk/main/features.c 314594 
  trunk/res/res_features.exports.in 314594 

Diff: https://reviewboard.asterisk.org/r/1185/diff


Testing
-------

pickup using *8 feature code, with pickup sounds enabled/disabled

exten => 71,1,Pickup()           ; any ringing extension in same pickupgroup 
exten => 72,1,Pickup(85 at phones)  ; dahdi extension
exten => 73,1,Pickup(823 at phones) ; sip extension


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110421/bd98720f/attachment-0001.htm>