[asterisk-dev] [Code Review] Add MixMonitor and StopMixMonitor AMI actions

David Vossel reviewboard at asterisk.org
Wed Apr 20 16:02:15 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1193/#review3414
-----------------------------------------------------------


MixMonitor has a few other options that could be used for the manager action as well, but I don't know how important that is.  Over All this looks very good!


http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1193/#comment7045>

    It is possible that mixmonitor_exec could fail.  If this happens, a success response should not be sent.


- David


On 2011-04-20 15:30:33, telecos82 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1193/
> -----------------------------------------------------------
> 
> (Updated 2011-04-20 15:30:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add MixMonitor and StopMixMonitor AMI actions to allow starting and stopping MixMonitor from AMI.
> 
> 
> This addresses bug 19155.
>     https://issues.asterisk.org/view.php?id=19155
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c 314406 
> 
> Diff: https://reviewboard.asterisk.org/r/1193/diff
> 
> 
> Testing
> -------
> 
> Tested with SIP, IAX and DAHDI channels.
> 
> 
> Thanks,
> 
> telecos82
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110420/b5f0576e/attachment-0001.htm>


More information about the asterisk-dev mailing list