[asterisk-dev] [Code Review] Add manager event for early media

Olle E. Johansson oej at edvina.net
Mon Apr 18 14:00:47 CDT 2011


18 apr 2011 kl. 19.14 skrev Russell Bryant:

> This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1187/
> 
> Since it's not an actual channel state, why don't we make this a new event type?

I started down that path but kind of gave up. Adding it as a channel state was the easiest way.  Adding it as a new event "MediaState" implied that we have to indicate state for every media stream, which we have not got yet.

I know that if we add it like this, it will just have to stay, even if it ends up being in the wrong place when we get the new media architecture. Regardless, I think this was the easiest way today and I can live with having it like this.

Responses from developers using AMI also indicated that this was the way they expect it to be, both on the list and the developers I work with.

/O


More information about the asterisk-dev mailing list