[asterisk-dev] [Code Review] Chan_local crashes in local_fixup

Russell Bryant reviewboard at asterisk.org
Fri Apr 15 05:21:44 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1158/#review3374
-----------------------------------------------------------

Ship it!


Harmless change, go for it

- Russell


On 2011-04-15 03:25:37, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1158/
> -----------------------------------------------------------
> 
> (Updated 2011-04-15 03:25:37)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> Chan_local crashes in local_fixup where new code assumes that both p->owner and p->chan exists. In our core dump, p->chan was null.
> 
> 
> This addresses bug 19053.
>     https://issues.asterisk.org/view.php?id=19053
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.2/channels/chan_local.c 312284 
> 
> Diff: https://reviewboard.asterisk.org/r/1158/diff
> 
> 
> Testing
> -------
> 
> This was discovered during a stress test. We'll continue and report back if it crashes again after fixing. Result: Crashes disappeared.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110415/8eec3d56/attachment.htm>


More information about the asterisk-dev mailing list