[asterisk-dev] [Code Review] chan_sip directed pickup deadlock

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1175/#review3331
-----------------------------------------------------------



/team/bbryant/sip-call-pickup/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1175/#comment6926>

    Does the channel need a reference held here before it gets unlocked?  Its seems like c could either be a new channel, or a previously allocated channel stored on the p->owner at this point.


- David


On 2011-04-13 12:35:33, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1175/
> -----------------------------------------------------------
> 
> (Updated 2011-04-13 12:35:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes a deadlock which would cause ast_do_masquerade to request a channel lock while already holding a sip_pvt structure, violating locking order and causing deadlocks each time a directed pickup was finished locking up asterisk entirely holding the channels lock.
> 
> 
> Diffs
> -----
> 
>   /team/bbryant/sip-call-pickup/channels/chan_sip.c 313524 
> 
> Diff: https://reviewboard.asterisk.org/r/1175/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110413/be2fa6b8/attachment-0001.htm>