[asterisk-dev] [Code Review] Add 'description' field for SIP peers

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1163/
-----------------------------------------------------------

(Updated 2011-04-07 12:57:51.128001)


Review request for Asterisk Developers.


Changes
-------

Based on the feedback provided by oej, I went and learned a lot more today.

chan_dahdi.conf, sip.conf, and iax.conf all now support the new 'description' field.

Additionally, I added the Description field to the manager interface output for DAHDIShowChannels, SIPshowpeer, SIPpeers, and IAXpeers. Please double check that I put the Description field in the right spot as I'm not sure the best way to add the field without breaking existing configurations.


Summary
-------

Using some of the best practices names for SIP peers provides the quandary of knowing exactly what peer is where, or who it is assigned to.

If you name all your peers as the MAC address of the device, then it's difficult to determine what device is assigned to whom, or at least knowing where the device physically resides.

I've added a description field that can help. When you do 'sip show peers' then a new column called Description outputs 32 chars of a description to the Asterisk console.


This addresses bug 19076.
    https://issues.asterisk.org/view.php?id=19076


Diffs (updated)
-----

  trunk/CHANGES 313091 
  trunk/channels/chan_dahdi.c 313091 
  trunk/channels/chan_iax2.c 313091 
  trunk/channels/chan_sip.c 313091 
  trunk/channels/sip/include/sip.h 313091 
  trunk/configs/chan_dahdi.conf.sample 313091 
  trunk/configs/iax.conf.sample 313091 
  trunk/configs/sip.conf.sample 313091 

Diff: https://reviewboard.asterisk.org/r/1163/diff


Testing
-------

Added "description=My Awesome Peer" to [0004f2040001] definition in sip.conf, then did 'sip show peers' and 'sip show peer 0004f2040001'. Output was as expected. Compiled without error or warning.


Thanks,

Leif

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110407/6fe95775/attachment.htm>